From c25433766498bcc58f7fe802d3d0050e617ae65c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Einar=20J=C3=B8rgen=20Haraldseid?= Date: Sat, 16 Feb 2019 09:47:20 +0100 Subject: [PATCH] Fix minor complaints from shellcheck --- imgurgame.bash | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/imgurgame.bash b/imgurgame.bash index 88af620..ef09841 100755 --- a/imgurgame.bash +++ b/imgurgame.bash @@ -7,14 +7,16 @@ readonly BROWSER="google-chrome" imgururl() { # 1/3 chance for length of 5, 6 or 7 length string STRLN=$((5 + ${RANDOM} % 3)) - local ID=$(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w ${STRLN} | head -n 1) + local ID + ID=$(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w ${STRLN} | head -n 1) echo "http://i.imgur.com/${ID}.jpg" } # Test if we found a valid URL testimgur() { local URL=${1} - local RESULT=$(curl -s -o /dev/null -I -w "%{http_code}" ${URL}) + local RESULT + RESULT=$(curl -s -o /dev/null -I -w "%{http_code}" ${URL}) if [[ ${RESULT} == "200" ]]; then echo true else @@ -25,7 +27,8 @@ testimgur() { main() { local FAIL=0 while true; do - local URL=$(imgururl) + local URL + URL=$(imgururl) if [[ $(testimgur ${URL}) == "true" ]]; then echo "Found ${URL} after ${FAIL} failed tries" ${BROWSER} ${URL} > /dev/null 2>&1 -- 2.30.2